Make Windows Python setup more standard #15578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using my own Python install, because I was testing on a local
machine, but it's true that we should use the GHA Python setup tools for
this.
Thanks @tylerjereddy for the comment:
#15563 (review)
I agree too that the post-install is a little gruesome. In fact we have
the same stuff implemented in Python in the
dev.py
script. It mightbe better to refactor that out into something in the
_build_tools
directory, and run it as single Python command instead.
dev.py
could import the same code.
Reference issue
What does this implement/fix?
Additional information