Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Windows Python setup more standard #15578

Merged
merged 1 commit into from Feb 12, 2022

Conversation

matthew-brett
Copy link
Contributor

I was using my own Python install, because I was testing on a local
machine, but it's true that we should use the GHA Python setup tools for
this.

Thanks @tylerjereddy for the comment:
#15563 (review)

I agree too that the post-install is a little gruesome. In fact we have
the same stuff implemented in Python in the dev.py script. It might
be better to refactor that out into something in the _build_tools
directory, and run it as single Python command instead. dev.py
could import the same code.

Reference issue

What does this implement/fix?

Additional information

@tylerjereddy tylerjereddy added maintenance Items related to regular maintenance tasks Meson Items related to the introduction of Meson as the new build system for SciPy labels Feb 12, 2022
@tylerjereddy tylerjereddy added this to the 1.9.0 milestone Feb 12, 2022
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the CircleCI timeout is not related.

The new windows job is already a few minutes faster than the old build system Windows jobs. I imagine we'll have better traction to evaluate the discrepancy in build times on different operating systems/compilers later on (I think I already saw the use of a ninja profiler in chrome in one of the PRs/tools, which I've used at work as well..).

@tylerjereddy tylerjereddy merged commit ff1d155 into scipy:main Feb 12, 2022
@tylerjereddy
Copy link
Contributor

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks Meson Items related to the introduction of Meson as the new build system for SciPy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants