DEV: Try to detect scipy from dev installed path #15725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smit-create
added
DX
|
@Smit-create thanks! Can you point out what the difference with the old PR or the exact problem was? |
Smit-create
commented
Mar 10, 2022
Comment on lines
+282
to
+283
| test, version, mod_path = get_project_info() | ||
|
|
There was a problem hiding this comment.
This was previously under if/else statement so didn't run when we used it with the building option. Now, this is fixed here.
rgommers
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
I did some testing, this does the right thing for -s, -t and other flags now. Thanks @Smit-create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15640 (comment)
cc @rgommers