Make Umfpack free its data (#1597) #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error on deprecation should be reverted before release in Numpy. But why are you seeing it? I don't you adding anything that can cause a new one here. Either way those warnings should be filtered out of the tests. |
|
@pv Yes, the patch seems ok. |
|
@rgommers: the DeprecationWarning raised by the umfpack routines is converted into an error, so these tests are not otherwise ran when using the dev version of Numpy. |
rgommers
added a commit
that referenced
this pull request
Feb 18, 2012
Make Umfpack free its data (#1597)
|
I'll backport to 0.10.x too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this: http://projects.scipy.org/scipy/ticket/1597
Can't really add an unit test for this, since the data is held on C level.
@rc: do you concur?
The WarningManager stuff is for present Numpy.