Skip to content

Make Umfpack free its data (#1597) #162

Merged
merged 2 commits into from Feb 18, 2012

3 participants

@pv
SciPy member
pv commented Feb 15, 2012

Fixes this: http://projects.scipy.org/scipy/ticket/1597
Can't really add an unit test for this, since the data is held on C level.

@rc: do you concur?

The WarningManager stuff is for present Numpy.

@rgommers
SciPy member

The error on deprecation should be reverted before release in Numpy. But why are you seeing it? I don't you adding anything that can cause a new one here.

Either way those warnings should be filtered out of the tests.

@rc
rc commented Feb 16, 2012

@pv Yes, the patch seems ok.

@pv
SciPy member
pv commented Feb 16, 2012

@rgommers: the DeprecationWarning raised by the umfpack routines is converted into an error, so these tests are not otherwise ran when using the dev version of Numpy.

@rgommers rgommers merged commit d24cc56 into scipy:master Feb 18, 2012
@rgommers
SciPy member

I'll backport to 0.10.x too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.