Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: update benchmarking docs to use dev.py user interface #16633

Merged
merged 5 commits into from Sep 4, 2022

Conversation

hfactor13
Copy link
Contributor

@hfactor13 hfactor13 commented Jul 17, 2022

The runtest.py module is being phased out in favor of the dev.py module.

Reference issue

What does this implement/fix?

This fixes the documentation to include the new test module.

Additional information

The runtest.py module is being phased out in favor of the dev.py module.
@j-bowhay j-bowhay added Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org Benchmarks Running, verifying or documenting benchmarks for SciPy labels Jul 17, 2022
The runtest.py module is being phased out in favor of the dev.py module.
[skip azp] [skip actions]
@tylerjereddy
Copy link
Contributor

I think the other commands will need revising too--I just did a few spot checks to get you started down the right path.

@tupui tupui added the sprint Mentored-Sprint. Please do not work on this unless you're participating to a sprint label Jul 18, 2022
@rgommers
Copy link
Member

rgommers commented Sep 1, 2022

@hfactor13 this change would be good to get merged. Are you planning to update this PR?

@rgommers rgommers changed the title Updating benchmarking.rst documentation DOC: update benchmarking docs to use dev.py user interface Sep 1, 2022
@hfactor13
Copy link
Contributor Author

Yes, I just have to run the tests and I think I should be good.

Replaced "--bench" with "bench" for running all benchmarks, and "bench -t" for running specific benchmarks.
@hfactor13
Copy link
Contributor Author

I just pushed my commits. Let me know if there's anything else I am missing.

Also update the doc command for it

[skip ci]
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hfactor13. There was one more issue with the bench --compare command, I fixed the docs and the actual implementation so it runs correctly now. In it goes.

@rgommers rgommers merged commit cd07fac into scipy:main Sep 4, 2022
@rgommers rgommers added this to the 1.10.0 milestone Sep 4, 2022
@hfactor13 hfactor13 deleted the my-dev-branch branch October 29, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmarks Running, verifying or documenting benchmarks for SciPy Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org sprint Mentored-Sprint. Please do not work on this unless you're participating to a sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants