BLD: update meson and meson-python versions for 1.9.0 release
#16671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
Build issues
rgommers
force-pushed
the
update-build-deps-1.9.x
branch
from
9f29c7d
to
6d0eedf
Compare
This works around an issue where `pip install .` or `python -m build` end up with a `py3-none` wheel tag, rather than the correct ABI tag. Pinning the Meson version in `pyproject.toml` will only affect wheel building, and should be fine. For the change to `meson.build`, the upper bound doesn't seem to work. This was never tested before, and is safe to remove.
rgommers
force-pushed
the
update-build-deps-1.9.x
branch
from
6d0eedf
to
9d40737
Compare
tylerjereddy
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Sounds good, the doc build failure is almost certainly not related. I grepped the warnings below. I think this PR claims to close itself, maybe a typo, I'll check for the actual issue.
WARNING: failed to reach any of the inventories with the following issues:
/home/circleci/repo/build-install/lib/python3.8/site-packages/scipy/signal/_filter_design.py:docstring of scipy.signal._filter_design.freqz:86: WARNING: py:func reference target not found: matplotlib.pyplot.plot
/home/circleci/repo/build-install/lib/python3.8/site-packages/scipy/spatial/_plotutils.py:docstring of scipy.spatial._plotutils.delaunay_plot_2d:29: WARNING: py:obj reference target not found: matplotlib.pyplot.triplot
/home/circleci/repo/doc/source/reference/generated/scipy.special.gegenbauer.rst:21: WARNING: py:obj reference target not found: matplotlib.pyplot
/home/circleci/repo/build-install/lib/python3.8/site-packages/scipy/stats/_morestats.py:docstring of scipy.stats._morestats.boxcox_normplot:19: WARNING: py:obj reference target not found: matplotlib.pyplot
/home/circleci/repo/build-install/lib/python3.8/site-packages/scipy/stats/_morestats.py:docstring of scipy.stats._morestats.ppcc_plot:29: WARNING: py:obj reference target not found: matplotlib.pyplot
/home/circleci/repo/build-install/lib/python3.8/site-packages/scipy/stats/_morestats.py:docstring of scipy.stats._morestats.probplot:29: WARNING: py:obj reference target not found: matplotlib.pyplot
/home/circleci/repo/build-install/lib/python3.8/site-packages/scipy/stats/_morestats.py:docstring of scipy.stats._morestats.yeojohnson_normplot:19: WARNING: py:obj reference target not found: matplotlib.pyplot
Maybe matplotlib docs issue/connectivity issue?
intersphinx inventory 'https://matplotlib.org/stable/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: 522 Server Error: for url: https://matplotlib.org/stable/objects.inv
Ah sorry, I meant gh-16555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around an issue where
pip install .orpython -m buildend up with apy3-nonewheel tag, rather than the correct ABI tag.Pinning the Meson version in
pyproject.tomlwill only affect wheel building, and should be fine.Closes gh-16555