New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP, DOC: Show deprecated methods in docs and fix overwriting with _deprecated
#16866
Conversation
[skip azp] [skip actions]
gilbrat is deprecated and now is included in the docs until v1.11 Until then docs, show a clear deprecation warning redirecting the user to gibrat
Thanks for sorting this! Is it worth adding to the |
Yes, definitely! I'd recommend using the decorator over the numpy decorator because it is clean, internal, easy to tweak, and avoids repetition of the warning unlike numpy decorator. But before this PR, it was overwriting the docstring which is also not ideal. The |
This is ready for review; some changes here need to be merged first (if everything looks ok) to unblock #15901. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me, and removing lines from the refguide checker is always a good sign. Thanks @AnirudhDagar.
Reference issue
#16846
What does this implement/fix?
scipy._lib.deprecation._deprecated
. Now the complete docstring is utilized and one must create a deprecated directive to show the warninng.gilbrat
andkulsinski
to the documentation with appropriate deprecation warning at the top of the docs. Users can follow the suggested alternate method from the deprecation warning (the links should be clickable after soon upgrading topydata-sphinx-theme>=0.10.0
). Note that the removal ofNumericalInverseHermite
is set for SciPy 1.10.0, hence it is ok to remove it from the toctree. (these were removed in DOC: remove deprecated functions from refguide #16273)plot_pre_code
warning filtering list inconf.py
. DEP: Deprecate scipy.misc in favour of scipy.datasets #15901 will follow the same pattern to avoid failure of the plot directive. Any docstring example with plotting which uses a deprecation function in the future should be added to this list.