Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: stats.crosstab: convert output tuple to bunch #16958

Merged
merged 4 commits into from Sep 5, 2022
Merged

ENH: stats.crosstab: convert output tuple to bunch #16958

merged 4 commits into from Sep 5, 2022

Conversation

j-bowhay
Copy link
Member

@j-bowhay j-bowhay commented Sep 4, 2022

Reference issue

#16364 (comment)

What does this implement/fix?

Converts crosstab to return a bunch rather than a plain tuple

Additional information

@j-bowhay j-bowhay added scipy.stats enhancement A new feature or improvement labels Sep 4, 2022
mdhaber
mdhaber approved these changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@mdhaber mdhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@j-bowhay
Copy link
Member Author

j-bowhay commented Sep 5, 2022

I think doc failure is now related to #16960? Do you want me to rebase and run again (just the doc build as the rest seems fine / unrelated)

@mdhaber
Copy link
Contributor

mdhaber commented Sep 5, 2022 •
edited

You can just merge rather than rebasing. Please add [skip actions] [skip azp] to the body of the commit message to run only CircleCI. (Those used to work, although not sure if azure is skipping now.)

@j-bowhay
Copy link
Member Author

j-bowhay commented Sep 5, 2022

Doc build now green and rendering correctly 😃

@mdhaber mdhaber merged commit cd57132 into scipy:main Sep 5, 2022
@mdhaber
Copy link
Contributor

mdhaber commented Sep 5, 2022

Thanks @j-bowhay!

@j-bowhay j-bowhay deleted the gh-16364 branch September 5, 2022 16:09
@mdhaber mdhaber added this to the 1.10.0 milestone Nov 29, 2022
@j-bowhay j-bowhay mentioned this pull request Aug 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdhaber mdhaber mdhaber approved these changes

Assignees
No one assigned
Labels
enhancement A new feature or improvement scipy.stats
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j-bowhay @mdhaber