-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: bump boost-headers-only to 1.80.0 #17207
Conversation
@@ -3,7 +3,7 @@ | |||
url = https://github.com/scipy/scipy-mathjax.git | |||
[submodule "scipy/_lib/boost"] | |||
path = scipy/_lib/boost | |||
url = https://github.com/scipy/boost-headers-only | |||
url = https://github.com/mckib2/boost-headers-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a leftover from local tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be changed -- doing some testing to see if we can jump straight to Boost 1.80.0
EDIT: see scipy/boost-headers-only#10
@h-vetinari CI failure here looks unrelated to Boost changes -- no rush, but if you have a chance to look at impacts to conda-forge and it works, besides the OpenBSD/FreeBSD patch and updating scipy/boost-headers-only, this might be ready to go |
Could you rebase on main? There are several CI fails on macosx_arm64 that I'm hoping my get fixed by this PR. The CI infrastructure isn't present yet in your branch. |
Should have latest main now as well as latest upstream patch for M1 compiler bug |
It doesn't fix the issues we're seeing on macosx_arm64 on cirrus. |
These should both be fixed in Boost 1.81.0. #14901 was fixed with boostorg/math#827 |
It looks like gh-17146 is fixed by boostorg/math#847, too. Thanks @mborland! Do you think we can get 1.81 before SciPy 1.10.0 releases, @mckib2? |
Boost 1.81 is scheduled to release the 14 of December. Do you use the standalone version of Boost.Math, or the Boost super project? If you are using the standalone we can cut a 1.80.1 in the event 1.81 doesn't meet your timeline. |
We have been generating headers from the "regular" Boost distribution which includes most of the super-project. I believe we did it this way as we thought we might anticipate using other Boost libraries, but I don't think that's a huge concern for us now. Boost.Math is really all we need. @mdhaber @rgommers Is it worth the small refactor in scipy/boost-headers-only to use the standalone version of Boost.Math? It's unclear to me if anyone else is now relying on that repo to provide more than just Boost.Math. |
Anyone else in SciPy? I don't think so. I think you reviewed the only other use of Boost in SciPy that I know of, which is (presumably Math) in |
That does sound like a good idea to me - smaller checkouts, and more flexible in terms of releases it looks like. No one else should be relying on that repo, and in case they do they can just fork it and do their own thing. This is meant for SciPy only. One thing to keep in mind is to not lose the old commits in the |
Please revert as much of gh-17272 as possible when this PR gets merged. |
If we use the standalone version of Boost.Math, we may no longer need the machinery around the Boost headers-only repo. In this case, closing this PR in favor of gh-17432 which includes Boost.Math directly |
On the other hand, we've discussed using additional parts of Boost, like the |
It can always be reverted. Boost is huge, so adding a dependency on more of it probably needs a separate conversation. Looking at those topics, it also seems that those may not materialize. |
No. There are precious few Boost libraries that support their own standalone mode. For most you need the whole monolith (which is one of the most common complaints against Boost). While not a complete replacement for Boost.Odeint if you are looking to expand |
Reference issue
What does this implement/fix?
Additional information