BLD: update to Meson 0.64.0, remove pure: false lines
#17372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new feature in Meson is both safer and saves a bunch of boilerplate. There are also other fixes in Meson 0.64.0 that we need; they were mostly backported to 0.63.3, but older versions have a few known issues that we should avoid. Meson release note: https://mesonbuild.com/Release-notes-for-0-64-0.html#pythonfind_installation-now-accepts-pure-argument
rgommers
added
maintenance
rgommers
requested review from
person142,
tylerjereddy,
peterbell10,
perimosocordiae,
larsoner,
ilayn,
andyfaff and
ev-br
as code owners
tupui
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new feature in Meson is both safer and saves a bunch of boilerplate. There are also other fixes in Meson 0.64.0 that we need; they were mostly backported to 0.63.3, but older versions have a few known issues that we should avoid.
Meson release note: https://mesonbuild.com/Release-notes-for-0-64-0.html#pythonfind_installation-now-accepts-pure-argument