-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Update testing documentation to dev.py #17573
Conversation
@melissawm how are you going with this? It's looking pretty good to me, are there any further changes you would like to make? |
[skip azp] [skip actions] [skip cirrus]
I think I got everything now - a few files are still mentioning runtests:
I think we shouldn't remove the runtests mention from the meson docs because they are actually talking about how the workflow has changed, and we can ignore the release notes. But I'm not sure what to do with the benchmark docs. I also assume CI should not be changed before runtests is effectively removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update Melissa. LGTM. Ok to not touch the meson part until we remove this. And yes AFAIK we are still missing a few things to migrate CI. For benchmarking, I think we should be able to update though (can be done in a follow up).
@rgommers any other comments before we get this in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, thanks @melissawm
Update the developer documentation to mention
dev.py test
instead ofruntests.py
.This PR is still a draft - it was made during the Newcomer's meeting.
Reference issue
Partially addresses #17373
What does this implement/fix?
Additional information