BUG: Fix handling of powm1 overflow errors
#17855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2023
Co-authored-by: Warren Weckesser <warren.weckesser@gmail.com>
j-bowhay
added
defect
WarrenWeckesser
approved these changes
Jan 26, 2023
|
Thanks @mborland, merged. The existing tests should cover this case. |
This was referenced Jan 27, 2023
tylerjereddy
added
the
backport-candidate
|
I think this was a precursor attempt at bug fix prior to gh-17872, so I'll add backport label here as well |
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
Feb 18, 2023
2 tasks
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
No open issue. Fixes handling of overflow errors that are on the Boost.Math develop branch found in #17432
What does this implement/fix?
Overflow errors always returned positive infinity. This changes the behavior based on the value of x to return negative infinity such as in the failing test case:
x = -INF, y = 3Additional information
N/A