Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: make sure macosx_x86_64 10.9 tags are being made on maintenance/1.10.x #17981

Merged
merged 1 commit into from Feb 16, 2023

Conversation

andyfaff
Copy link
Contributor

This PR makes sure that macosx_x86_64 wheels are being tagged correctly as 10_9. Wheels were being incorrectly tagged as 10_15 due to the issue being reported in pypa/cibuildwheel#1419.

This PR is made against the maintenance/1.10.x branch because the issue will be fixed as part of #17950, and we don't want to include the entire PR because it's also bumping things like OpenBLAS.

Before this is merged the committer (@tylerjereddy ?) should check that the wheel build for macosx_x86_64 is producing wheels tagged as 10_9, not 10_15.

@andyfaff andyfaff added maintenance Items related to regular maintenance tasks backport-candidate This fix should be ported by a maintainer to previous SciPy versions. labels Feb 16, 2023
CIBW_ENVIRONMENT_MACOS: >
MACOSX_DEPLOYMENT_TARGET=10.9
MACOS_DEPLOYMENT_TARGET=10.9
_PYTHON_HOST_PLATFORM=macosx-10.9-x86_64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we may get a point release per mesonbuild/meson-python#309 (comment), but I agree that making this change is definitely the right solution at the moment and keeps us safe with either variable name.

I checked that the new wheel names for MacOS x86_64 have 10_9 tag--i.e., this log: https://github.com/scipy/scipy/actions/runs/4190628420/jobs/7264230310

We can see that the old wheels used for 1.10.0 wheel build had 10_15 per https://github.com/scipy/scipy/actions/runs/3832354403/jobs/6522562479 (and indeed, per the wheels on PyPI proper at https://pypi.org/project/scipy/1.10.0/#files). NumPy doesn't seem to have that problem for their most recent patch release.

The Windows wheel build failures here are because of #17934, which is addressed by the backport-labeled PR #17936, so merging thanks!

@tylerjereddy tylerjereddy merged commit caf5ce8 into scipy:maintenance/1.10.x Feb 16, 2023
@tylerjereddy tylerjereddy added this to the 1.10.1 milestone Feb 16, 2023
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Feb 16, 2023
@andyfaff andyfaff deleted the mactag branch February 16, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants