MAINT: stats.dgamma.entropy: avoid deprecated NumPy usage and simplify #18349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
added
scipy.stats
maintenance
dschmitz89
approved these changes
Apr 23, 2023
tupui
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Toward gh-18331
What does this implement/fix?
gh-18331 notes that tests of
stats.dgamma.entropyare failing due to a NumPy deprecation. This attempts to avoid the deprecated NumPy usage. Incidentally, it also simplifies the override by relying onstats.gamma._entropyto perform the calculation.Additional information
See #18162 (comment) for related derivation. The same approach can be used for any similar "double" distributions.
gh-18352 will fix the pesky lint failure.