New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: sparse: Generalize coo_array to support 1d shapes #18530
Merged
Merged
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
45aa3fa
Squashed changes
perimosocordiae 05a75ce
fix misc test and mypy errors
dschult 3133513
Merge pull request #10 from dschult/coo-1d-fix
perimosocordiae b7fe14f
Minor tweaks on top of Dan's PR
perimosocordiae 97cad34
manually unravel to avoid 32bit overflows
dschult c2cc3b8
Merge pull request #11 from dschult/coo-1d-unravel
perimosocordiae c53aae8
More tweaks on top of Dan's PR
perimosocordiae 6caca81
leftpad in toarray, row, col; coo 1darrays now row=0, col=indexes
dschult 365ba55
change M -> A for dense array
dschult 85894f9
change row property
dschult 51ed57e
add unified interface _shape_as_2d to get 2d version of shape
dschult 68f244b
revert non-1d related changes
dschult c67b340
Merge pull request #12 from dschult/coo-1d-row0
perimosocordiae d471acb
Merge branch 'main' into coo-1d
perimosocordiae 7fb0853
Rename allow_ndim to allow_1d
perimosocordiae 966415d
gentle handling of 1d in other code
dschult 41b7592
add test for block_diag and make work
dschult 59b7340
Merge pull request #13 from dschult/coo-1d_issparse
perimosocordiae 473e32f
Merge branch 'main' into coo-1d
perimosocordiae 264533f
Fix lint issue
perimosocordiae File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name is OK for now, but needs to be changed if we ever support any other dimensionality than 1 and 2.