New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: version bounds for 1.11.0rc1 #18591
MAINT: version bounds for 1.11.0rc1 #18591
Conversation
* the version bounds are easy to mess up--the reference conversation from the last release is linked below: scipy#17569 * the adjustment of version strings to include i.e., `rc1` is normally left to the `REL` commit proper during the release process
8585dd6
to
df477e6
Compare
There's a segfault on alpine in CI: The prerelease failure is working as I currently intend it: |
you can ignore that segfault. I couldn't pinpoint the exact time but when multiple workers are fired, it runs out of memory somehow in the linalg tests. I already reduced the numbers on certain tests but I think it is dying because there are too many tests in that module ~3k LOC file. |
I think Cython 3 compatibility would be good to have also on the 1.11 branch. We should be pretty close already, hopefully any relevant patches would be small and easy to backport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Cython <3.0 looks correct to me, we are likely to see more breakage there so should exclude it. The Python 3.12 support could go either way; I suggest allowing it already because it likely works and early adopters are starting to build for it from source.
* allow Python `3.12` based on reviewer feedback
Revised to allow Python |
To expand on my answer: we add a |
This is what I meant as well. 👍 |
@@ -53,6 +53,9 @@ endif | |||
if not cy.version().version_compare('>=0.29.35') | |||
error('SciPy requires Cython >= 0.29.35') | |||
endif | |||
if not cy.version().version_compare('<3.0') | |||
error('SciPy requires Cython < 3.0') | |||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually work exactly as intended unfortunately, because .version_compare
does not deal with pre-releases. So a 3.0.0b3
version will choke on this check. Now, that may be intended since those pre-releases aren't really supported. However, the 3.0 release is expected soon and it actually does work. So I think we should remove this check again. We'll keep it in pyproject.toml
, so by default users who pip install scipy
and get a from-source build will get the latest 0.29.x version. But if they are explicitly using 3.0, let's let them do that.
the version bounds are easy to mess up--the reference conversation from the last release is linked below:
MAINT: version bounds for 1.10.0rc1/relnotes fixes #17569
the adjustment of version strings to include i.e.,
rc1
is normally left to theREL
commit proper during the release processOther vague things on my mind include:
2.0
coming sooner than later--I'm not sure this really requires any special action at the time of writing--I suspect producing a helpful error message with a major version change is the behavior we want for now3.12