Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT:linalg.det:Return scalars for singleton inputs #18763

Merged
merged 1 commit into from Jun 27, 2023

Conversation

ilayn
Copy link
Member

@ilayn ilayn commented Jun 26, 2023

Reference issue

What does this implement/fix?

Closes #18759

Additional information

The test suite missed the scalar input inside singleton numpy array case. It's fixed in this PR.

@ilayn ilayn added scipy.linalg maintenance Items related to regular maintenance tasks backport-candidate This fix should be ported by a maintainer to previous SciPy versions. labels Jun 26, 2023
@ilayn ilayn added this to the 1.11.1 milestone Jun 26, 2023
@ilayn ilayn requested a review from larsoner as a code owner June 26, 2023 23:02
Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ilayn for the quick fix. LGTM (usual failure in CI)

@tupui tupui merged commit 61d892c into scipy:main Jun 27, 2023
23 of 24 checks passed
@ilayn ilayn deleted the fix1by1det branch June 27, 2023 10:17
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request Jun 28, 2023
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

determinant of a 1x1 matrix returns an array, not a scalar
3 participants