MAINT: fix unuran licensing #18778
Merged
MAINT: fix unuran licensing #18778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes scipy#18765 * the offending unuran source file was removed over at scipy/unuran#9, and this PR updates us to point to latest `main` version of submodule (caution: this pulls in a few more commits from `main` we didn't have in original `1.11.0` release) * as noted over there, the (SciPy) testsuite appears to pass just fine when this file is purged, likely because we have `HAVE_DECL_LOG1P` always set, since we require C99, and therefore unuran always uses the version from `math.h` instead of in-house anyway
tylerjereddy
added
scipy.stats
maintenance
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Licensing concern #18765
the offending unuran source file was removed over at MAINT: remove license violation unuran#9,
and this PR updates us to point to latest
mainversion of submodule (caution: this pulls in a few more commits from unuran submodulemainwe didn't have in original1.11.0release, and I've just assumed they are safe, which they probably are since all appear to be inget_and_clean_unuran.py)as noted over there, the (SciPy) testsuite appears to pass just fine when this file is purged, likely
because we have
HAVE_DECL_LOG1Palways set, since we require C99, and therefore unuran always usesthe version from
math.hinstead of in-house anyway