Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add compile and link args to show_config output #18848

Merged
merged 1 commit into from Jul 9, 2023
Merged

ENH: add compile and link args to show_config output #18848

merged 1 commit into from Jul 9, 2023

Conversation

ganesh-k13
Copy link
Contributor

Changes

  • ENH: Added compiler args and link_args

Testing

~/os/scipy (enh_config_flags*) » meson setup build -Dc_args="-O2" -Dc_link_args="-ftree-vectorize" -Dcpp_args="-O2" -Dcpp_link_args="-ftree-vectorize"

SciPy 1.12.0.dev0                
                                                         
  User defined options
    prefix       : /home/ganesh/os/scipy/build-install
    c_args       : -O2
    c_link_args  : -ftree-vectorize
    cpp_args     : -O2
    cpp_link_args: -ftree-vectorize

~/os/scipy (enh_config_flags*) » python3 dev.py ipython

In [1]: import scipy
                                                         
In [2]: scipy.show_config()
Compilers:
  c:
    args: -O2
    commands: ccache, cc
    linker: ld.bfd
    linker args: -ftree-vectorize
    name: gcc
    version: 11.3.0
  c++:
    args: -O2
    commands: ccache, c++
    linker: ld.bfd
    linker args: -ftree-vectorize
    name: gcc
    version: 11.3.0
  cython:
    commands: cython
    linker: cython
    name: cython
    version: 0.29.36
  fortran:
    commands: gfortran
    linker: ld.bfd
    name: gcc
    version: 11.3.0
  pythran:
    include directory: ../../sci/lib/python3.10/site-packages/pythran
    version: 0.12.1.

References

Backport of numpy/numpy@15d93b4
NumPy issue and PR:

cc: @rgommers

@ganesh-k13 ganesh-k13 requested a review from rgommers as a code owner July 9, 2023 04:34
@j-bowhay j-bowhay added enhancement A new feature or improvement Meson Items related to the introduction of Meson as the new build system for SciPy labels Jul 9, 2023
@rgommers rgommers added this to the 1.12.0 milestone Jul 9, 2023
rgommers
rgommers approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ganesh-k13!

@rgommers rgommers changed the title ENH: Added compiler args and link_args ENH: add compile and link args to show_config output Jul 9, 2023
@rgommers rgommers merged commit 64a533e into scipy:main Jul 9, 2023
22 of 24 checks passed
alugowski pushed a commit to alugowski/scipy that referenced this pull request Jul 16, 2023
@ganesh-k13 @alugowski
ENH: Added compiler args and link_args (scipy#18848)
3c34208 
Backport of numpy/numpy@15d93b4
Ref:
    - numpy/numpy#24094
    - numpy/numpy#24034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
enhancement A new feature or improvement Meson Items related to the introduction of Meson as the new build system for SciPy
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ganesh-k13 @rgommers @j-bowhay