Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: from CONTRIBUTING.rst link to SciPy website #18910

Merged
merged 2 commits into from Jul 18, 2023

Conversation

TiloRC
Copy link
Contributor

@TiloRC TiloRC commented Jul 18, 2023

Links in CONTRIBUTING.rst went to other .rst files rather than the SciPy website.

This is problematic because the links in the other .rst files don’t work unless they are rendered. Furthermore, new contributors are likely to see CONTRIBUTING.rst because it is linked from the new contributors popup.

This commit fixes the issue by linking to the SciPy website from CONTRIBUTING.rst rather than other .rst files.

Also, the link to John Hunter's BSD pitch has suffered from link rot, so I replaced the link to a new link to an archive of the website.

Reference issue

Closes #18903.

Links in CONTRIBUTING.rst went to other .rst files rather than
the SciPy website. This is problematic because the links in the
other .rst files don’t work unless they are rendered.

Furthermore, new contributors are likely to see CONTRIBUTING.rst
because it is linked from the new contributors popup.

This commit fixes the issue by linking to the SciPy website from
CONTRIBUTING.rst rather than other .rst files.

Also, the link to John Hunter's BSD pitch has suffered from link
rot, so I replaced the link to a new link to an archive of the
website.

Closes scipy#18903.
Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick PR @TiloRC 🚀

Just removing the points as some browser might see it and return a 404. And then I am merging.

CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@tupui tupui merged commit 2c05d12 into scipy:main Jul 18, 2023
1 check passed
@tupui tupui added this to the 1.12.0 milestone Jul 18, 2023
@tupui tupui added the Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: links in hacking.rst go back to hacking.rst instead of their intended destinations.
2 participants