Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/BLD: create cp312 wheels #18937

Merged
merged 19 commits into from Jul 22, 2023
Merged

CI/BLD: create cp312 wheels #18937

merged 19 commits into from Jul 22, 2023

Conversation

andyfaff
Copy link
Contributor

This PR adds the machinery to build cp312 wheels for the as-yet unreleased Python 3.12

@andyfaff andyfaff requested a review from larsoner as a code owner July 22, 2023 08:11
@rgommers rgommers added CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure Official binaries Items related to the official SciPy binaries, including wheels and vendored libs labels Jul 22, 2023
@rgommers
Copy link
Member

Thanks @andyfaff!

The macOS failure looks like a connection error in download_openblas, I started a re-run to see if it passes. The Windows failure is:

sf_error.obj : error LNK2001: unresolved external symbol wrap_PyUFunc_getfperr

It seems to correctly install numpy-1.22.4 in the pip-packages stage, so it's not immediately clear to me what is going wrong there.

@andyfaff
Copy link
Contributor Author

I think the windows fail is unrelated. I've touched nothing that would cause issues there

@andyfaff
Copy link
Contributor Author

macOS entry passes now. Feel free to squash merge.

@rgommers rgommers added this to the 1.12.0 milestone Jul 22, 2023
rgommers
rgommers approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, in it goes!

I think the windows fail is unrelated. I've touched nothing that would cause issues there

Agreed, it's not even in a wheel build but in the one CI job that still uses setup.py.

@rgommers rgommers merged commit da3639e into scipy:main Jul 22, 2023
40 of 42 checks passed
@rgommers
Copy link
Member

I triggered wheel builds on main, so we should see nightly wheels for 3.12 appear in the next hour or so.

@lesteve
Copy link
Contributor

lesteve commented Jul 24, 2023

Very nice 🎉, thanks!

@lesteve lesteve mentioned this pull request Jul 24, 2023
Closed
@andyfaff andyfaff mentioned this pull request Aug 10, 2023
Closed
@tylerjereddy tylerjereddy added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Aug 10, 2023
@tylerjereddy tylerjereddy modified the milestones: 1.12.0, 1.11.2 Aug 10, 2023
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request Aug 10, 2023
@andyfaff @tylerjereddy
CI/BLD: create cp312 wheels (scipy#18937)
16dd1f1 
[wheel build]
@tylerjereddy tylerjereddy mentioned this pull request Aug 10, 2023
Merged
5 tasks
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

Assignees
No one assigned
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure Official binaries Items related to the official SciPy binaries, including wheels and vendored libs
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andyfaff @rgommers @lesteve @tylerjereddy