New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add possibility to fix parameters in multivariate normal fit #18986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you point to the reference that the math is as simple as this when one shape is fixed?
@dschmitz89 I took another quick look but I wasn't sure that you were done addressing comments. Please ping me when you think this is ready for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very close. Just a few suggestions.
Co-authored-by: Matt Haberland <mhaberla@calpoly.edu>
Thanks @mdhaber , I was about to fix the last errors now but you already went ahead, much appreciated. |
What does this implement/fix?
This is a follow up from #18361: add the possibility to fix mean and covariance during fitting a multivariate normal to data. Such functionality is built in for univariate distributions. The math is pretty straight forward, the tricky parts are useful error messages.