Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: use copy utility from #19014 in cluster #19055

Merged
merged 2 commits into from Aug 17, 2023

Conversation

lucascolley
Copy link
Member

Reference issue

n/a

What does this implement/fix?

Applies the copy utility from #19014 to the code added to cluster in #18668.

Additional information

cc: @andyfaff

@lucascolley lucascolley marked this pull request as ready for review August 12, 2023 12:32
@lucascolley
Copy link
Member Author

CI Lint:

scipy/cluster/hierarchy.py:4021:8: E721 Do not compare types, use `isinstance()`

The offending code:

if type(i) is not int:

Let me know whether that fix belongs in this PR or a separate one.

@rgommers rgommers added the array types Items related to array API support and input array validation (see gh-18286) label Aug 12, 2023
@andyfaff
Copy link
Contributor

I don't know why it's complaining about the lint, those lines haven't been touched. Yes, can you fix the lint issue, it'll prevent it coming up again.
Otherwise LGTM.

@lucascolley
Copy link
Member Author

Lint is happy now. I changed to using isinstance on two other lines as well just in case.

@andyfaff
Copy link
Contributor

Do you know what's going on with the docs build?

@lucascolley
Copy link
Member Author

lucascolley commented Aug 14, 2023

I have no idea... there aren't any changes to the docs here.

Edit: #19061

@lucascolley
Copy link
Member Author

This should be ready to merge now that the docs build is fixed!

@andyfaff andyfaff merged commit 42f6916 into scipy:main Aug 17, 2023
18 of 23 checks passed
@andyfaff
Copy link
Contributor

thank you @lucascolley

@lucascolley lucascolley deleted the cluster_copy branch August 17, 2023 10:04
@j-bowhay j-bowhay added this to the 1.12.0 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
array types Items related to array API support and input array validation (see gh-18286) scipy.cluster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants