BLD: Replace complex occurences with singlecomplex in SuperLU #19062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C/C++
rgommers
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Thanks @lysnikolaou! CI has some unrelated failures, however this all looks good - the patch file applies for me locally, and fixes the build problems.
Fixes for the other issues have either landed or are in flight, so I'll retrigger this once there's a new numpy nightly with the fix we need here to make CI run.
- Replace all occurences of complex with singlecomplex - Add a second patch file for the complex changes (to make it easier to remove once the upstream patch is merged) Closes scipygh-19036.
rgommers
force-pushed
the
superlu-complex
branch
from
ee5d192
to
ab8e93b
Compare
|
All happy now, in it went. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-19036.