ENH: Allow sparse_mtx.transpose(axes=(1, 0))
#19162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjereddy
changed the title
sparse_mtx.transpose(axes=(1, 0))sparse_mtx.transpose(axes=(1, 0))
tylerjereddy
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Alright, core dev approval and CI is happy with new test, and the diff is simple enough.
I've labelled as an enhancement, if you relabel as bug fix then add backport candidate label if you can remember.
I guess there is some confusion about how this might work with array api transpose, but sparse + array API is bit farther away anyway I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #19161
What does this implement/fix?
Allows
sparse_mtx.transpose(axes=(1, 0)), since that is equivalent tosparse_mtx.TAdditional information
Probably an enhancement, maybe a bug fix?