Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Import fromarrays from rec #19183

Merged
merged 1 commit into from Sep 5, 2023
Merged

MAINT: Import fromarrays from rec #19183

merged 1 commit into from Sep 5, 2023

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Sep 5, 2023 •
edited

Hi @rgommers,

This PR addresses changes introduced in numpy/numpy#24634. I only found one place that imported core explicitly. This change is backward compatible.

@melissawm melissawm added the maintenance Items related to regular maintenance tasks label Sep 5, 2023
rgommers
rgommers approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mtsokol. This one snuck in after I last checked for numpy.core/np.core usage.

@rgommers rgommers added this to the 1.12.0 milestone Sep 5, 2023
@rgommers rgommers merged commit 384bb38 into scipy:main Sep 5, 2023
21 of 24 checks passed
@mtsokol mtsokol deleted the numpy-core-refactor branch September 5, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
maintenance Items related to regular maintenance tasks
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtsokol @rgommers @melissawm