TST: test tolerance bumps to fix reported failures #19192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes scipygh-19117 The `test_sygst` one was reported in scipygh-19153.
tylerjereddy
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
LGTM and reduces my test failure count locally on M2 max as well. I still have 1 or 2 others that seem stochastic, but I'll just update gh-18308 for those.
The MacOS CI failure is unrelated and showing up in other PRs. One of the linting failures is somewhat real due to a now-unused sys import, but we can clean that up later.
rgommers
added
the
backport-candidate
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-19117
The
test_sygstone was reported in gh-19153.