New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Added examples for zpk2tf, tf2sos, sos2tf, lp2lp_zpk, lp2hp_zpk, lp2bp_zpk, lp2bs_zpk functions #19218
Conversation
… lp2bp_zpk, lp2bs_zpk functions#
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tamri, some suggestions
Co-authored-by: Jake Bowhay <60778417+j-bowhay@users.noreply.github.com>
… lp2bp_zpk, lp2bs_zpk functions
…into docustring-examples Pull changes
Hey @j-bowhay, I made changes accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refguide check / doc build needs fixing. Looks like some of the docstrings need converting to raw strings (r"""
) and some of the expected outputs are wrong
@j-bowhay It seems like all checks passed. Can you please take another look at this PR. |
Co-authored-by: Jake Bowhay <60778417+j-bowhay@users.noreply.github.com>
Co-authored-by: Jake Bowhay <60778417+j-bowhay@users.noreply.github.com>
…into docustring-examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tamri
Reference issue
DOC: Add "Examples" to docstrings #7168
What does this implement/fix?
Added examples for zpk2tf, tf2sos, sos2tf, lp2lp_zpk, lp2hp_zpk, lp2bp_zpk, lp2bs_zpk functions
The code can be found in scipy/signal/_filter_design.py
Additional information
[skip actions] [skip cirrus]