DEP: improve message for deprecated private API for sparse
#19226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I in the sparse submodule
TST: fix test for sparse.linalg
hoangle96
changed the title
sparse
j-bowhay
requested changes
Sep 12, 2023
scipy/_lib/tests/test_public_api.py
Outdated
| ('scipy.stats.biasedurn', None), | ||
| ('scipy.stats.kde', None), | ||
| ('scipy.stats.morestats', None), | ||
| ('scipy.stats.mstats_basic', 'mstats'), | ||
| ('scipy.stats.mstats_extras', 'mstats'), | ||
| ('scipy.stats.mvn', None), | ||
| ('scipy.stats.stats', None)]) | ||
|
|
scipy/sparse/bsr.py
Outdated
| return getattr(_bsr, name) | ||
| return _sub_module_deprecation(sub_package="sparse", module="bsr", | ||
| private_modules=["_bsr"], all=__all__, | ||
| attribute=name) |
There was a problem hiding this comment.
New line at end of file needed
scipy/sparse/data.py
Outdated
| return getattr(_data, name) | ||
| return _sub_module_deprecation(sub_package="sparse", module="data", | ||
| private_modules=["_data"], all=__all__, | ||
| attribute=name) |
scipy/sparse/linalg/eigen.py
Outdated
Comment on lines
9
to
12
| 'ArpackError', | ||
| 'ArpackNoConvergence', | ||
| 'eigs', | ||
| 'eigsh', 'lobpcg', 'svds', 'arpack', 'test' |
There was a problem hiding this comment.
can you revert the change here please
scipy/sparse/linalg/isolve.py
Outdated
Comment on lines
9
to
23
| 'bicg', | ||
| 'bicgstab', | ||
| 'cg', | ||
| 'cgs', | ||
| 'gcrotmk', | ||
| 'gmres', | ||
| 'lgmres', | ||
| 'lsmr', | ||
| 'lsqr', | ||
| 'minres', | ||
| 'qmr', | ||
| 'tfqmr', | ||
| 'utils', | ||
| 'iterative', | ||
| 'test' |
There was a problem hiding this comment.
again please revert this change it makes it harder to tell if anything has been removed
scipy/sparse/linalg/matfuncs.py
Outdated
Comment on lines
9
to
18
| 'expm', | ||
| 'inv', | ||
| 'solve', | ||
| 'solve_triangular', | ||
| 'spsolve', | ||
| 'is_pydata_spmatrix', | ||
| 'LinearOperator', | ||
| 'UPPER_TRIANGULAR', | ||
| 'MatrixPowerOperator', | ||
| 'ProductOperator' |
scipy/sparse/linalg/eigen.py
Outdated
| return _sub_module_deprecation(sub_package="sparse.linalg", module="eigen", | ||
| private_modules=["_eigen"], all=__all__, | ||
| attribute=name) | ||
|
|
There was a problem hiding this comment.
one too many lines at end of file!
j-bowhay
changed the title
sparsesparse
j-bowhay
added
scipy.sparse
deprecated
hoangle96
commented
Sep 13, 2023
j-bowhay
requested changes
Sep 13, 2023
scipy/sparse/bsr.py
Outdated
| return getattr(_bsr, name) | ||
| return _sub_module_deprecation(sub_package="sparse", module="bsr", | ||
| private_modules=["_bsr"], all=__all__, | ||
| attribute=name) |
scipy/sparse/linalg/isolve.py
Outdated
Comment on lines
9
to
23
| 'bicg', | ||
| 'bicgstab', | ||
| 'cg', | ||
| 'cgs', | ||
| 'gcrotmk', | ||
| 'gmres', | ||
| 'lgmres', | ||
| 'lsmr', | ||
| 'lsqr', | ||
| 'minres', | ||
| 'qmr', | ||
| 'tfqmr', | ||
| 'utils', | ||
| 'iterative', | ||
| 'test' |
There was a problem hiding this comment.
again please revert this change it makes it harder to tell if anything has been removed
|
@j-bowhay I have updated the changes to be PEP8 complaint and revert the unnecessary changes. |
j-bowhay
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Thanks @hoangle96! Congratulations on your first contribution to SciPy, if you are interested in doing one of the other modules from the issue that would be greatly appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Solving a part of issue gh-18279
closes #19241
What does this implement/fix?
Finish #18279 for
sparseAdditional information