Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: fft: clean up assertions #19282

Merged
merged 1 commit into from Sep 23, 2023
Merged

MAINT: fft: clean up assertions #19282

merged 1 commit into from Sep 23, 2023

Conversation

lucascolley
Copy link
Member

Reference issue

Towards gh-19257.
See gh-19251 for similar efforts in cluster.

What does this implement/fix?

  • We consistently use actual, desired in the correct order as arguments of our assertions, xp_assert_close and xp_assert_equal.
  • Some dtype conversions are removed where we were previously comparing actual real arrays with desired complex arrays. Using xp.real on the desired value is sufficient.

@lucascolley
MAINT/TST: fft: clean up assertions
8b19514 
[skip cirrus] [skip circle]
@lucascolley lucascolley mentioned this pull request Sep 22, 2023
Open
9 tasks
@lucascolley lucascolley changed the title MAINT/TST: fft: clean up assertions MAINT: fft: clean up assertions Sep 22, 2023
@rgommers rgommers added maintenance Items related to regular maintenance tasks scipy.fft array types Items related to array API support and input array validation (see gh-18286) labels Sep 23, 2023
@rgommers rgommers added this to the 1.12.0 milestone Sep 23, 2023
rgommers
rgommers approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lucascolley

@rgommers rgommers merged commit 71ae314 into scipy:main Sep 23, 2023
22 of 23 checks passed
@lucascolley lucascolley deleted the fft-assertions branch September 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
array types Items related to array API support and input array validation (see gh-18286) maintenance Items related to regular maintenance tasks scipy.fft
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucascolley @rgommers