MAINT: remove support for building with setup.py #19317
Conversation
With Python 3.12 available and the Meson build mature, we don't need this any longer. The last reason we kept this around is to allow conda-forge to use it on Windows. That isn't possible anymore with Python 3.12, and conda-forge builds on Windows with Meson are now close enough to the finish line (a first build with Clang + Flang managed to create a wheel, still work to do though).
rgommers
requested review from
larsoner,
person142,
steppi,
tylerjereddy,
peterbell10,
perimosocordiae,
ilayn,
andyfaff and
ev-br
as code owners
yeah... I'd only delete this once we have meson-based windows builds in conda-forge, to be honest... 😅 We've run through compilation (not yet installation) so far, but not yet the test suite, much less benchmarks... I wish I could accelerate this process more, but I need a bit of advice on meson where I'm bottlenecked by the response times of those in the know... |
The trade-off is getting worse though - the last bug we just encountered was the last drop. I'd rather get rid of it and if we really really need it still come January for 1.12.0, we can put it back in the release branch. That's easier for me to do in one go, compared to asking every contributor that touches the build system to deal with two build systems. |
I'm not going to stand in the way, just noted my gut feeling (wasn't involved with the bugs you mentioned). It'll probably bitrot quite badly if we remove it, but ideally the time until January is sufficient for getting windows builds unblocked and we won't need it again 🤞 |
|
I don't think we'll need it again - and also it'll give a positive incentive (for me) to work on the structural improvement rather than hanging on to the band-aid:) |
|
Well, good news, I gave a bit of a push, and conda-forge/scipy-feedstock#255 now passes the test suite. 🥳 So LGTM to remove |
|
Awesome work on getting a Clang/Flang build working on Windows @h-vetinari! |
…s.sh` This was useful during debugging, but no longer does anything. The `test.f` file that was called was removed in a previous commit in this PR (19317). [skip ci]
|
Two core devs/both rel managers in favor of merge, so merged. Maybe there will be a few other related cleanups we find later, which is fine. |
With Python 3.12 available and the Meson build mature, we don't need this any longer. The last reason we kept this around is to allow conda-forge to use it on Windows. That isn't possible anymore with Python 3.12, and conda-forge builds on Windows with Meson are now close enough to the finish line (a first build with Clang + Flang managed to create a wheel, still work to do though).