MAINT, BLD: more setup.py cleanups #19331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deal with the `setup.py`-related `TODO` comment in the `stats` build system surrounding `templated_pyufunc.pxd`, now that we no longer have `setup.py` * remove `setup.py` handling from our coverage config (I think our coverage infrastructure is a bit dormant at the moment in any case) * remove some stray comments/other configs related to `setup.py` * I've avoided some potentially more complex cleanups for now, like `messagestream_config.h.in` (and yes, there are other places in the `meson` build system where we can cleanup, but I'm less confident to tackle those at this time) [skip cirrus]
tylerjereddy
requested review from
larsoner,
andyfaff,
perimosocordiae and
rgommers
as code owners
rgommers
reviewed
Oct 2, 2023
There was a problem hiding this comment.
Thanks Tyler, these are useful cleanups. For the two codegen scripts, I suggest making the outdir option required, otherwise they're left in a bit of a weird state where the CLI flag seems optional but the case where it's not provided is no longer handled and then you get a build error later on.
* restore a comment about skipping `g77_abi_wrappers` on 32-bit, but switch the `setup.py` reference to past tense * `code_gen.py` and `_generate_pyx.py` will now error out if `outdir` is not provided [skip cirrus]
|
Ok, I pushed in attempted revisions based on the first round of comments. |
rgommers
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deal with the
setup.py-relatedTODOcomment in thestatsbuild system surroundingtemplated_pyufunc.pxd, now that we no longer havesetup.pyremove
setup.pyhandling from our coverage config (I think our coverage infrastructure is a bit dormant at the moment in any case)remove some stray comments/other configs related to
setup.pyI've avoided some potentially more complex cleanups for now, like
messagestream_config.h.in(and yes, there are other places in themesonbuild system where we can cleanup, but I'm less confident to tackle those at this time)[skip cirrus]