DOC, MAINT: more distutils/build cleanups #19390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove some modules in `_build_utils` that don't seem relevant now that we use `meson` exclusively * update the detailed roadmap to remove the mention of removing support for `numpy.distutils` (it is true that there are still `meson` things to do of course, but `setup.py` is gone now) * the paragraph about Pythran in the detailed roadmap was also deleted--it is no longer an optional dep [skip cirrus]
tylerjereddy
added
Documentation
ilayn
reviewed
Oct 15, 2023
doc/source/dev/roadmap-detailed.rst
Outdated
| @@ -75,15 +67,6 @@ NumPy C API (by Cython, everything in SciPy was fixed) will disappear. Then we | |||
| can define ``NPY_NO_DEPRECATED_API`` unconditionally. | |||
There was a problem hiding this comment.
Actually this also happened. Not relevant but just saying.
There was a problem hiding this comment.
I think 99% there, but it's only fully true if we drop Cython 2.x and then update our use of numpy_nodepr_api.
rgommers
approved these changes
Oct 17, 2023
| ``SCIPY_USE_PYTHRAN=0``. The aim is to make it a hard dependency - for that to | ||
| happen it must be clear that the maintenance burden is low enough (Meson will | ||
| help here, because it removes the monkey patching that is now done to enable | ||
| Pythran). |
There was a problem hiding this comment.
This is actually still optional - it can be disabled with -Duse-pythran=false instead of the old env var.
doc/source/dev/roadmap-detailed.rst
Outdated
| @@ -75,15 +67,6 @@ NumPy C API (by Cython, everything in SciPy was fixed) will disappear. Then we | |||
| can define ``NPY_NO_DEPRECATED_API`` unconditionally. | |||
There was a problem hiding this comment.
I think 99% there, but it's only fully true if we drop Cython 2.x and then update our use of numpy_nodepr_api.
| 'pathf95': ['-i8'], # PathScale Fortran compiler | ||
| 'pg': ['-i8'], # Portland Group Fortran Compiler | ||
| 'flang': ['-i8'], # Portland Group Fortran LLVM Compiler | ||
| 'sun': ['-i8'], # Sun or Forte Fortran 95 Compiler |
There was a problem hiding this comment.
This whole file seems fine to remove indeed - when we need it, we can dig it up from the 1.11.x branch.
* restore/update the Pythran roadmap content based on reviewer feedback [skip cirrus]
|
Ok, I tried to restore/update the Pythran part of the roadmap. |
rgommers
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove some modules in
_build_utilsthat don't seem relevant now that we usemesonexclusively (it may be possible that a subset of the ideas get reused for ilp64 support in meson (?), but I suspect that will use meson idioms instead)update the detailed roadmap to remove the mention of removing support for
numpy.distutils(it is true that there are stillmesonthings to do of course, butsetup.pyis gone now)the paragraph about Pythran in the detailed roadmap was also deleted--it is no longer an optional dep
[skip cirrus]