MAINT: spatial: Change error message in KDTree to be more informative. #19391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the discussion in scipy#19188, change the error message to make it clearer that we're dealing with a 2D numpy array, but the data in the array can be any dimension (1D, 2D, ...).
j-bowhay
requested changes
Oct 15, 2023
j-bowhay
reviewed
Oct 15, 2023
Co-authored-by: Jake Bowhay <60778417+j-bowhay@users.noreply.github.com>
j-bowhay
changed the title
j-bowhay
added
scipy.spatial
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #19188
What does this implement/fix?
Based on the discussion in #19188, change the error message when calling KDTree with an invalid data array to make it clearer that data should be a 2D array, but the data in the array can be any dimension (1D, 2D, ...).
Additional information
I'm not sure if this is exactly what the people involved had in mind, but it's a quick and simple fix.