ENH: stats.bartlett: add axis / nan_policy / keepdims support #19392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tirthasheshpatel if this looks good other than the merge conflict, I think it will be safe to resolve it and commit with |
tirthasheshpatel
approved these changes
Oct 19, 2023
|
Oops, when resolving merge conflicts using the web interface, it doesn't allow you to change the commit message : / |
|
No worries, I just merged so the runs should be cancelled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Toward gh-14651
What does this implement/fix?
Adds axis / nan_policy / keepdims support to
scipy.stats.bartlett.Additional information
Similar to
ansari(gh-19371), for Nd input,bartlettreturns a scalar result. However, the result seems to be garbage - it's different fromaxis=None/ raveling the arrays before passing them to the function. So I think it's safe to letaxis=0be the default since there's no useful behavior to maintain.