ENH: stats.levene/fligner: add axis / nan_policy / keepdims support #19428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
commented
Oct 24, 2023
tirthasheshpatel
approved these changes
Nov 7, 2023
perimosocordiae
pushed a commit
to perimosocordiae/scipy
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Toward gh-14651
What does this implement/fix?
Adds axis / nan_policy / keepdims support to
scipy.stats.leveneandscipy.stats.fligner.Additional information
@tirthasheshpatel Based on our discussion about the trimmed statistics, I'm assuming it's ok if
proportiontocutonly supports scalars?flignerhad special handling for size-0 arrays, so I updated it to return NaN of the correct dtype.levenedid not - it just pops out of the calculation. But the calculation never respects dtype, including when the array is of size-0. I don't see a need to fix that at this time.