TST: Fix #19442 minimally #19443
Merged
TST: Fix #19442 minimally #19443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a sorted version of the set REAL_DTYPES to parameterize test_b_orthonormalize.
musicinmybrain
force-pushed
the
issue-19442
branch
from
7013a2d
to
2841380
Compare
tylerjereddy
added
maintenance
tylerjereddy
approved these changes
Oct 28, 2023
There was a problem hiding this comment.
I'm "ok" with this fix. I couldn't reproduce locally, even with a huge number of replicate tests via pytest-repeat (python dev.py test -j 8 -t scipy/sparse/linalg/_eigen/lobpcg/tests/test_lobpcg.py::test_b_orthonormalize -- --count=1000) on latest main, but since the pytest-xdist docs (and intuition) clearly support your claim, I think this is fine to merge.
I noticed discussion of other more systematic improvements related to these tests in the matching issue, but I think patching the immediate/simplest problem first is fine here for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #19442.
What does this implement/fix?
This fixes #19442 minimally by parameterizing
test_b_orthonormalizeover a sorted-list version of the setREAL_DVALUES.Additional information
As reported in #19442 (comment), I tried paramet(e)rizing over
VDTYPESinstead, but the tests involving complex dtypes failed.Future work could perhaps make this test pass with
VDTYPES, and perhaps even add a test with complex dtypes having complex values, as suggested at the end of #19442 (comment).