DEP: special: improve deprecation of private modules named without underscore prefix #19469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-bowhay
added
scipy.special
deprecated
lucascolley
reviewed
Nov 6, 2023
scipy/special/orthogonal.py
Outdated
| return getattr(_orthogonal, name) | ||
| return _sub_module_deprecation(sub_package="special", module="orthogonal", | ||
| private_modules=["_orthogonal"], all=__all__, | ||
| attribute=name) |
scipy/special/sf_error.py
Outdated
| return getattr(_sf_error, name) | ||
| return _sub_module_deprecation(sub_package="special", module="sf_error", | ||
| private_modules=["_sf_error"], all=__all__, | ||
| attribute=name) |
h-vetinari
reviewed
Nov 8, 2023
j-bowhay
commented
Nov 8, 2023
[skip ci] Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
j-bowhay
force-pushed
the
special_mod_deps
branch
from
0727df7
to
d172874
Compare
lucascolley
requested changes
Nov 8, 2023
lucascolley
approved these changes
Nov 8, 2023
perimosocordiae
pushed a commit
to perimosocordiae/scipy
that referenced
this pull request
Nov 8, 2023
…derscore prefix (scipy#19469) * DEP: special: improve deprecation of private modules named without underscore prefix * STY: fix style issues [skip ci] Co-authored-by: Lucas Colley <lucas.colley8@gmail.com> --------- Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
towards #18279
What does this implement/fix?
Currently, some deprecation warnings for private modules named without underscore prefixes are misleading. For example:
Before this pr:
After:
Additional information