MAINT: Update fast_matrix_market to 1.7.4 #19472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep in sync with upstream. The changes are purely on the C++ side. Mainly: * Fix `#include` errors on GCC 13, though this has already been patched in scipy#19409 * Support for C++23 fixed-width floating point types, and string types. * New mechanism to handle `symmetric` Matrix Market files. May in the future replace the current Python method.
|
Check fails in unrelated modules. Upstream tests on 32-bit Linux and Python 3.12. |
j-bowhay
added
scipy.io
maintenance
tylerjereddy
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
LGTM, I'm familiar with the two unrelated CI failures.
Since you're also the upstream maintainer of the vendored code, it is a pretty easy decision. When I poked around on the branch locally I did notice that the git timestamp on the commit looked a bit old (February 2023), but that's irrelevant really.
I don't think we can directly use new C++23 stuff just yet, but test suite seems happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep in sync with upstream.
The changes are purely on the C++ side. Mainly:
#includeerrors on GCC 13, though this has already been patched in MAINT: fix a C++ build error with GCC 13 #19409symmetricMatrix Market files. May in the future replace the current Python method.