Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: limit scipy-openblas32 wheel to 0.3.23.293.2 #19484

Merged
merged 2 commits into from Nov 9, 2023

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Nov 7, 2023

I am working towards adding a scipy_ prefix to all the openblas symbol names in the scipy-openblas wheels. This will allow using both the scipy-openblas wheels and another OpenBLAS library together in scipy, for instance if using a scipy compiled with the "regular" OpenBLAS together with a numpy compiled with the OpenBLAS wheels.

In order to do an ordered transition, first this PR freezes the current version of scipy-openblas32 used in CI here. Then I will release new scipy-openblas32 wheels with an updated scipy-openblas.pc file, that will define a new -DBLAS_SYMBOL_PREFIX=scipy_ compile-time directive. Then I will come back to here and submit a new PR that reverts this one, and makes sure the use of BLAS_SYMBOL_PREFIX actually works.

@mattip
Copy link
Contributor Author

mattip commented Nov 7, 2023

xref @rgommers

@mattip
Copy link
Contributor Author

mattip commented Nov 7, 2023

Is there something wrong with the baseline support for numpy? I see this error in the meson 3.12-dev build

Error compiling Cython file:
------------------------------------------------------------
...

@cython.boundscheck(False)
@cython.wraparound(False)
cpdef void _categorize(cnp.float_t[::1] draws,
                       cnp.float_t[::1] p_cumulative,
                       cnp.int_t[::1] result) noexcept nogil:
                       ^
------------------------------------------------------------

/home/runner/work/scipy/scipy/scipy/stats/_sobol.pyx:409:23: 'int_t' is not a type identifier

@rgommers
Copy link
Member

rgommers commented Nov 7, 2023

That build failure with the numpy nightly is due to the int_t removal in numpy, and being worked on in gh-19466.

@rgommers rgommers added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Nov 7, 2023
@rgommers rgommers changed the title BLD: limit scipy-openblas32 wheel to 0.3.23.293.2 CI: limit scipy-openblas32 wheel to 0.3.23.293.2 Nov 7, 2023
@tylerjereddy tylerjereddy added this to the 1.12.0 milestone Nov 9, 2023
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we're familiar with the two failing CI jobs. I just checked that all three locations where we use scipy-openblas32 have their respective CI jobs still passing in the matrix for this branch, so in it goes I think so you can move forward with the symbol work.

@tylerjereddy tylerjereddy merged commit a901236 into scipy:main Nov 9, 2023
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants