Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT/STY: conftest.py: remove E501 (line length) lint ignore #19494

Merged
merged 2 commits into from Nov 9, 2023
Merged

MAINT/STY: conftest.py: remove E501 (line length) lint ignore #19494

merged 2 commits into from Nov 9, 2023

Conversation

lucascolley
Copy link
Member

Reference issue

Towards gh-19479.

What does this implement/fix?

Follow-up to gh-19489 for conftest.py.

Additional information

I'll add the blame-ignore once this looks ready.

@j-bowhay j-bowhay added the maintenance Items related to regular maintenance tasks label Nov 8, 2023
@lucascolley lucascolley marked this pull request as ready for review November 9, 2023 18:04
j-bowhay
j-bowhay approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here is so trivial that I don't think we need to worry about adding to the blame-ignore

@j-bowhay j-bowhay added this to the 1.12.0 milestone Nov 9, 2023
@j-bowhay j-bowhay merged commit d8f317f into scipy:main Nov 9, 2023
18 of 22 checks passed
@lucascolley lucascolley deleted the line-length-conftest branch November 9, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdhaber mdhaber mdhaber approved these changes

@j-bowhay j-bowhay j-bowhay approved these changes

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@rgommers rgommers Awaiting requested review from rgommers rgommers is a code owner

Assignees
No one assigned
Labels
maintenance Items related to regular maintenance tasks
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucascolley @mdhaber @j-bowhay