TST: skip test_bootstrap_against_theory #19501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* skip `test_bootstrap_against_theory()` on 32-bit architecture because it is failing fairly frequently in CI with a memory error; I thought about placing a more granular skip on just the `BCa` parameter, which is the case that actually fails, but since many tests in this module already have the broad 32-bit skip I figured I'd just do that with an explanation for now * one drawback to using our in-house `xfail_on_32bit` construct as done here is that we can't set `run=False`, which I might be inclined to do, since `MemoryError` subclasses aren't guaranteed to be safe to recover from, but it doesn't seem to actually cause a crash... [skip cirrus] [skip circle]
tylerjereddy
added
scipy.stats
maintenance
mdhaber
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip
test_bootstrap_against_theory()on 32-bit architecture because it is failing fairly frequently in CI with a memory error; I thought about placing a more granular skip on just theBCaparameter, which is the case that actually fails, but since many tests in this module already have the broad 32-bit skip I figured I'd just do that with an explanation for nowone drawback to using our in-house
xfail_on_32bitconstruct as done here is that we can't setrun=False, which I might be inclined to do, sinceMemoryErrorsubclasses aren't guaranteed to be safe to recover from, but it doesn't seem to actually cause a crash...[skip cirrus] [skip circle]
Example fails:
https://github.com/scipy/scipy/actions/runs/6788568241/job/18453856177?pr=19466
https://github.com/scipy/scipy/actions/runs/6803327498/job/18498407424?pr=19496