DOC, CI: refguide may vary locs #19525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add `# may vary` to two doc examples in attempt to repair refguide-check circleCI fails like this one: https://app.circleci.com/pipelines/github/scipy/scipy/23372/workflows/09f8210c-c813-44a7-88ec-7377cb1882d8/jobs/78647 * I actually see completely different issues with refguide locally, so wasn't able to repro + fix what we see in the CI locally [skip cirrus] [skip actions]
tylerjereddy
added
Documentation
|
The relevant CI run is green, the fix LGTM, so let's merge it quickly to unblock main. Thank you Tyler. |
Care to fix up or open an issue? Some things are just transients and may well depend on e.g.the linalg library (like one of the ones fixed here: the doctest was relying on specific phase choice of the eigenvector components, and this indeed may vary). |
tylerjereddy
added a commit
to tylerjereddy/scipy
that referenced
this pull request
Nov 15, 2023
* see: scipy#19525 (comment) * this allows the refguide check to pass for me locally; I use `openblas-0.3.23` from `spack` locally, maybe that's part of the difference [skip ci] [skip circle]
ev-br
pushed a commit
that referenced
this pull request
Nov 16, 2023
* DOC, MAINT: more refguide fixes * see: #19525 (comment) * this allows the refguide check to pass for me locally; I use `openblas-0.3.23` from `spack` locally, maybe that's part of the difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
# may varyto two doc examples in attempt to repair refguide-check circleCI fails like thisone:
https://app.circleci.com/pipelines/github/scipy/scipy/23372/workflows/09f8210c-c813-44a7-88ec-7377cb1882d8/jobs/78647
I actually see completely different issues with refguide locally, so wasn't able to repro + fix what we see in the CI locally
[skip cirrus] [skip actions]