Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix interpolate.make_smoothing_spline's size validation message. #19546

Merged
merged 1 commit into from Nov 22, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 17, 2023

"Greater than 5" means >5, "At least 5" means >=5 (which is the actual test, see the line immediately before the raise ValueError).

Reference issue

What does this implement/fix?

Additional information

"Greater than 5" means >5, "At least 5" means >=5 (which is the actual
test, see the line immediately before the `raise ValueError`).
@anntzer anntzer requested a review from ev-br as a code owner November 17, 2023 10:27
@j-bowhay j-bowhay added scipy.interpolate maintenance Items related to regular maintenance tasks labels Nov 17, 2023
@ev-br
Copy link
Member

ev-br commented Nov 22, 2023

LGTM and the CI failure in special is not related. Thanks @anntzer!

@ev-br ev-br merged commit 43f2e7d into scipy:main Nov 22, 2023
19 of 22 checks passed
@ev-br ev-br added this to the 1.12.0 milestone Nov 22, 2023
@anntzer anntzer deleted the msse branch November 22, 2023 16:06
@anntzer anntzer restored the msse branch November 22, 2023 16:06
@anntzer anntzer deleted the msse branch November 22, 2023 16:06
@anntzer anntzer restored the msse branch November 22, 2023 16:06
@anntzer anntzer deleted the msse branch November 22, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants