MAINT, BLD: poetry loongarch shims #19550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes scipygh-19189 * Fixes scipygh-19437 * I was able to reproduce both using `poetry install` inside of a mock project (https://github.com/tylerjereddy/poetry-demo) locally pointing to our latest `maintenance/1.11.x` branch * the changes in this patch allow the poetry version solving to pass locally; the basic idea was to bend over backwards to allow `loongarch` to be a special snowflake for Python up to `3.10` (the Windows combination can't happen anyway, as Ralf previously noted), and then to just let it follow the defaults at and beyond `3.11` * at the time of writing I don't think there's much hope to test this automatically in CI; even locally, I experienced extraordinarily slow dependency resolution times per python-poetry/poetry#2094 [skip cirrus]
tylerjereddy
added
Build issues
rgommers
approved these changes
Nov 18, 2023
This was referenced Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(PR against maintenance branch, the issue doesn't really exist on
main, or is at least a different situation there...)pyproject.tomlrequirements? #19189poetry installinside of a mock project (https://github.com/tylerjereddy/poetry-demo) locally pointing to our latestmaintenance/1.11.xbranch (fixing one of the issues cascades to the other)loongarchto be a special snowflake for Python up to3.10(the Windows combination can't happen anyway, as Ralf previously noted), and then to just let it follow the "defaults" at and beyond3.11[skip cirrus]