MAINT: interpolate/RGI: avoid unnecessary validation of data size #19591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RegularGridInterpolator allows changing the interpolation method at call site; if it is changed, data sizes need re-validation for a new method (cubics require at least four points and so on). At the call site, `__call__(..., method=None)` means that the interpolation method is the same as self.method and thus there is no need to re-validate self.values. RGI's interpolaton method (linear, cubic, etc) can be supplied in both `__init__` and `__call__`. The former is stored on the instance, and the latter allows changing the method for this particular call. Further, `__call__(..., method=None)` means 'use self.method'.
ev-br
force-pushed
the
rgi_method_is_changed
branch
from
a06411c
to
36abdac
Compare
ev-br
added
scipy.interpolate
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegularGridInterpolator allows changing the interpolation method at call site; if it is changed, data sizes need re-validation for a new method (cubics require at least four points and so on).
At the call site,
__call__(..., method=None)means that the interpolation method is the same as self.method and thus there is no need to re-validate self.values.Take this into account and avoid re-validation if
method is None