Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sparse multiply #19600

Merged
merged 5 commits into from Dec 5, 2023
Merged

Fix sparse multiply #19600

merged 5 commits into from Dec 5, 2023

Conversation

emilfrost
Copy link
Contributor

Reference issue

Closes gh-19599.

@lucascolley lucascolley added the enhancement A new feature or improvement label Dec 4, 2023
@perimosocordiae
Copy link
Member

Thanks for the PR and especially for adding a unit test. I've triggered the CI now.

@perimosocordiae
Copy link
Member

The CI failure is unrelated, so I'll merge this now. Thanks for the PR, @emilfrost !

@perimosocordiae perimosocordiae merged commit deeb67f into scipy:main Dec 5, 2023
27 of 28 checks passed
@emilfrost emilfrost deleted the fix_sparse_multiply branch December 5, 2023 13:56
@j-bowhay j-bowhay added this to the 1.12.0 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perimosocordiae perimosocordiae Awaiting requested review from perimosocordiae perimosocordiae is a code owner

Assignees
No one assigned
Labels
enhancement A new feature or improvement scipy.sparse
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

ENH: Returning NotImplemented when multiplying sparse arrays with unknown objects
4 participants
@emilfrost @perimosocordiae @lucascolley @j-bowhay