fix numerical stability #19617
Merged
fix numerical stability #19617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
added
defect
mdhaber
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Thanks @maciejskorski. Added a test. If CI comes back green, I'll merge.
Update: failures unrelated; merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #19616
What does this implement/fix?
Exponents in the pdf calculation are grouped together to avoid overflow and nans.
Additional information
The implementation should have three factors: one is to use the (scaled) Bessel function, another groups exponential terms (including the correction in Bessel's f) and the third one all remaining constants (typically small).