CI: undo cython==0.29.35 pin for the 32-bit Linux job, remove !=3.0.3
#19622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3` [wheel build] We're at Cython 3.0.6 now and the relevant upstream bugs have been fixed. We no longer need the `!=3.0.3` condition in CI jobs, because that version will never be installed anymore. We only keep it for now in `pyproject.toml` and in `environment.yml`, because there it is still useful information for downstream redistributors.
rgommers
added
maintenance
|
This LGTM. The fail on macosx_arm64 should be addressed by numpy/numpy#25285 (when it merges). Feel free to merge when everything else goes green. |
tylerjereddy
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're at Cython 3.0.6 now and the relevant upstream bugs have been fixed. We no longer need the
!=3.0.3condition in CI jobs, because that version will never be installed anymore. We only keep it for now inpyproject.tomland inenvironment.yml, because there it is still useful information for downstream redistributors.