Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: special: use indent width of 4 in clang-format #19660

Merged
merged 2 commits into from Dec 8, 2023

Conversation

lucascolley
Copy link
Member

Reference issue

#19613 (comment)
#19613 (comment)

What does this implement/fix?

  • Changes from indent width 2 to 4 in the clang-format of scipy/special/special
  • Adds git blame ignores for the style only changes

Additional information

@lucascolley lucascolley added this to the 1.12.0 milestone Dec 8, 2023
@lucascolley lucascolley added maintenance Items related to regular maintenance tasks scipy.special labels Dec 8, 2023
@lucascolley
Copy link
Member Author

@izaid I went ahead and did this

@steppi
Copy link
Contributor

steppi commented Dec 8, 2023

Thanks @lucascolley. While were at it, @izaid, is it cool if we set the ColumnLimit to something smaller like 90? I like to code with two windows open side by side.

Edit:
Ah, looks like the smaller column limit might cause trouble with SPECFUN_HOST_DEVICE in every function declaration

@izaid
Copy link
Contributor

izaid commented Dec 8, 2023

Thanks @lucascolley! That's actually really helpful!

I'm less keen on changing the columnwidth.

@steppi
Copy link
Contributor

steppi commented Dec 8, 2023

I'm less keen on changing the columnwidth

Yeah. I’m working on porting cephes stuff now and saw the shorter column width isn’t working out.

Copy link
Contributor

@steppi steppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@steppi steppi merged commit 1c3700c into scipy:main Dec 8, 2023
25 of 27 checks passed
@lucascolley lucascolley deleted the special-format branch December 8, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.special
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants