BLD: require Cython >=3.0.4, drop 0.29.X support #19714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make maintenance a bit easier, and it's time; NumPy dropped Cython 0.29.X support months ago and this has gone fine. This also fixes an annoying build warning that shows up twice, namely: ``` [5/7] Generating 'scipy/_lib/_ccallback_c.cpython-310-x86_64-linux-gnu.so.p/_ccallback_c.c' performance hint: /home/rgommers/code/scipy/scipy/_lib/_ccallback_c.pyx:138:82: Exception check will always require the GIL to be acquired. Declare the function as 'noexcept' if you control the definition and you're sure you don't want the function to raise exceptions. ``` The code is correct and not easy to change. It's only test code as well. The directive to silence the unhelpful hint was introduced in Cython 3.0.4, hence that's used as the new minimum version.
rgommers
added
scipy._lib
maintenance
tylerjereddy
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make maintenance a bit easier, and it's time; NumPy dropped Cython 0.29.X support months ago and this has gone fine.
This also fixes an annoying build warning that shows up twice, namely:
The code is correct and not easy to change. It's only test code as well. The directive to silence the unhelpful hint was introduced in Cython 3.0.4, hence that's used as the new minimum version.